Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119357811
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
---
@@ -795,13 +782,15 @@ public PojoSerializerConfigSnapshot(
this.nonRegisteredSubclassesToSerializerConfigSnapshots
=
Preconditions.checkNotNull(nonRegisteredSubclassesToSerializerConfigSnapshots);
- this.ignoreTypeSerializerSerialization =
ignoreTypeSerializerSerialization;
+ this.excludeSerializers = excludeSerializers;
}
@Override
public void write(DataOutputView out) throws IOException {
super.write(out);
+ out.writeBoolean(excludeSerializers);
+
// --- write fields and their serializers, in order
out.writeInt(fieldToSerializerConfigSnapshot.size());
--- End diff --
What I just noticed is that this is almost 3x duplicated code. I suggest to
create a private method that writes `Map<Class<?>, Tuple2<TypeSerializer<?>,
TypeSerializerConfigSnapshot>>` and call it 3 times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
