Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119364516
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -110,4 +123,20 @@ public boolean equals(Object obj) {
public int hashCode() {
return nestedSerializersAndConfigs.hashCode();
}
+
+ private Map<TypeSerializer<?>, Integer> buildSerializerIndices() {
--- End diff --
I see that the concrete implementation is always an identity hash map.
since it behaves different from what you expect by a normal map (using
equals/hashcode) and in that sense violates LSP, I suggest you wrap it in an
own class called `SerializerIndex`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
