Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4026#discussion_r119359879
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -110,4 +123,20 @@ public boolean equals(Object obj) {
public int hashCode() {
return nestedSerializersAndConfigs.hashCode();
}
+
+ private Map<TypeSerializer<?>, Integer> buildSerializerIndices() {
--- End diff --
While the idea makes sense, I am not sure if we can rely on all serializer
having a correct implementation of equals and hash code that will do what we
want. We might be better of with collection of `serializer -> index` pairs and
using equality for deduplication, but even there equals might be tricky. While
it is ok to accidentally write serializer twice, it should never happen that a
serializer gets de-duplicated by accident.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
