[
https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045897#comment-16045897
]
ASF GitHub Bot commented on FLINK-6841:
---------------------------------------
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4061
@twalthr @sunjincheng121 `DefinedProctimeAttribute` and
`DefinedRowtimeAttribute` doesn't work in batch table source, currently. BTW, I
don't think batch table source needs `DefinedRowtimeAttribute`. Users can use
an existing column as the row time attribute without declare the column as a
rowtime, isn't that right ?
For the following example, the `ts` is a physical column in table `T`.
```sql
SELECT overAgg(b, a) FROM T GROUP BY TUMBLE(ts, INTERVAL '2' HOUR)`
```
> using TableSourceTable for both Stream and Batch OR remove useless import
> -------------------------------------------------------------------------
>
> Key: FLINK-6841
> URL: https://issues.apache.org/jira/browse/FLINK-6841
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> 1. {{StreamTableSourceTable}} exist useless import of {{TableException}}
> 2. {{StreamTableSourceTable}} only override {{getRowType}} of
> {{FlinkTable}}, I think we can override the method in {{TableSourceTable}},
> If so we can using {{TableSourceTable}} for both {{Stream}} and {{Batch}}.
> What do you think? [~fhueske] [~twalthr]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
