[
https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045979#comment-16045979
]
ASF GitHub Bot commented on FLINK-6841:
---------------------------------------
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4061
Hi, @wuchong Thanks for your reviewing. I meant from the perspective of
grammar is allow batch table source to implement the `DefinedProctimeAttribute`
and `DefinedRowtimeAttribute`. We are on the same page about `batch table
source do not needs DefinedRowtimeAttribute`.
Thanks,
SunJincheng
> using TableSourceTable for both Stream and Batch OR remove useless import
> -------------------------------------------------------------------------
>
> Key: FLINK-6841
> URL: https://issues.apache.org/jira/browse/FLINK-6841
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> 1. {{StreamTableSourceTable}} exist useless import of {{TableException}}
> 2. {{StreamTableSourceTable}} only override {{getRowType}} of
> {{FlinkTable}}, I think we can override the method in {{TableSourceTable}},
> If so we can using {{TableSourceTable}} for both {{Stream}} and {{Batch}}.
> What do you think? [~fhueske] [~twalthr]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
