[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045974#comment-16045974 ]
ASF GitHub Bot commented on FLINK-6841: --------------------------------------- Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4061#discussion_r121282026 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalTableSourceUtilTest.scala --- @@ -42,7 +42,7 @@ class ExternalTableSourceUtilTest { val schema = new TableSchema(Array("foo"), Array(BasicTypeInfo.INT_TYPE_INFO)) val table = ExternalCatalogTable("mock", schema) val tableSource = ExternalTableSourceUtil.fromExternalCatalogTable(table) - assertTrue(tableSource.isInstanceOf[StreamTableSourceTable[_]]) + assertTrue(tableSource.isInstanceOf[TableSourceTable[_]]) --- End diff -- Make sense to me. :) > using TableSourceTable for both Stream and Batch OR remove useless import > ------------------------------------------------------------------------- > > Key: FLINK-6841 > URL: https://issues.apache.org/jira/browse/FLINK-6841 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Affects Versions: 1.4.0 > Reporter: sunjincheng > Assignee: sunjincheng > > 1. {{StreamTableSourceTable}} exist useless import of {{TableException}} > 2. {{StreamTableSourceTable}} only override {{getRowType}} of > {{FlinkTable}}, I think we can override the method in {{TableSourceTable}}, > If so we can using {{TableSourceTable}} for both {{Stream}} and {{Batch}}. > What do you think? [~fhueske] [~twalthr] -- This message was sent by Atlassian JIRA (v6.3.15#6346)