[
https://issues.apache.org/jira/browse/FLINK-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573266#comment-14573266
]
ASF GitHub Bot commented on FLINK-2160:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/785#discussion_r31746941
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java
---
@@ -399,13 +399,14 @@ private void writeSequence(StreamExecutionEnvironment
env, String topicName, fin
boolean running = true;
@Override
- public void run(Object checkpointLock,
Collector<Tuple2<Integer, Integer>> collector) throws Exception {
+ public void run(SourceContext<Tuple2<Integer, Integer>>
ctx) throws Exception {
LOG.info("Starting source.");
int cnt = from;
int partition =
getRuntimeContext().getIndexOfThisSubtask();
while (running) {
LOG.info("Writing " + cnt + " to
partition " + partition);
--- End diff --
I think we should downgrade this to "DEBUG" or "TRACE"
> Change Streaming Source Interface to run(Context)/cancel()
> ----------------------------------------------------------
>
> Key: FLINK-2160
> URL: https://issues.apache.org/jira/browse/FLINK-2160
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> This will make the source interface more extensible in the future without
> breaking existing sources (after the change). Right now, the context would
> have methods for element emission and for retrieving the checkpoint lock for
> checkpointed sources. In the future this can be extended to allow emission of
> elements with timestamp and for dealing with watermark emission.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
