[ 
https://issues.apache.org/jira/browse/FLINK-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573278#comment-14573278
 ] 

ASF GitHub Bot commented on FLINK-2160:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/785#issuecomment-108993818
  
    Good, mod some very minor comments.
    
    +1 from my side. I like it.


> Change Streaming Source Interface to run(Context)/cancel()
> ----------------------------------------------------------
>
>                 Key: FLINK-2160
>                 URL: https://issues.apache.org/jira/browse/FLINK-2160
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> This will make the source interface more extensible in the future without 
> breaking existing sources (after the change). Right now, the context would 
> have methods for element emission and for retrieving the checkpoint lock for 
> checkpointed sources. In the future this can be extended to allow emission of 
> elements with timestamp and for dealing with watermark emission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to