[
https://issues.apache.org/jira/browse/FLINK-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573270#comment-14573270
]
ASF GitHub Bot commented on FLINK-2160:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/785#discussion_r31747189
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -86,7 +85,7 @@ public void close() throws Exception {
}
@Override
- public void run(Object checkpointLock, Collector<OUT> out) throws
Exception {
+ public void run(SourceContext<OUT> ctx) throws Exception {
while (running) {
delivery = consumer.nextDelivery();
--- End diff --
Make delivery a stack reference. No need to hold a reference in a field
longer than necessary.
> Change Streaming Source Interface to run(Context)/cancel()
> ----------------------------------------------------------
>
> Key: FLINK-2160
> URL: https://issues.apache.org/jira/browse/FLINK-2160
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> This will make the source interface more extensible in the future without
> breaking existing sources (after the change). Right now, the context would
> have methods for element emission and for retrieving the checkpoint lock for
> checkpointed sources. In the future this can be extended to allow emission of
> elements with timestamp and for dealing with watermark emission.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
