Github user stevenzwu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4357#discussion_r128113797
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -517,16 +519,13 @@ public void
initializeState(FunctionInitializationContext context) throws Except
LOG.debug("Using the following offsets:
{}", restoredState);
}
}
- if (restoredState != null && restoredState.isEmpty()) {
- restoredState = null;
- }
} else {
LOG.info("No restore state for FlinkKafkaConsumer.");
}
}
@Override
- public void snapshotState(FunctionSnapshotContext context) throws
Exception {
+ public final void snapshotState(FunctionSnapshotContext context) throws
Exception {
--- End diff --
@tzulitai what's the reason to make this final? In our router use case, we
override the snapshotState method to no-op. We disabled Flink checkpoint by
setting checkpoint interval to Long.MAX_VALUE. we can't set Flink checkpoint to
false, because otherwise Kafka consumer auto.commit will be hard-coded to true.
@zhenzhongxu ^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
