Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4289#discussion_r129522998
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ---
    @@ -312,6 +312,48 @@ private void recoverWorkers() throws Exception {
        }
     
        @Override
    +   public void shutDown() throws Exception {
    +           // shut down all components
    +           if (taskMonitor != null) {
    +                   try {
    +                           actorSystem.stop(taskMonitor);
    --- End diff --
    
    We should try to gracefully stop the actors. I propose to use 
`Patterns.gracefulStop`, then collecting for all actors the returned futures, 
combining them and then wait on their completion with a timeout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to