Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4289#discussion_r129522795
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
---
@@ -312,6 +312,48 @@ private void recoverWorkers() throws Exception {
}
@Override
+ public void shutDown() throws Exception {
+ // shut down all components
+ if (taskMonitor != null) {
+ try {
+ actorSystem.stop(taskMonitor);
+ } catch (Throwable tt) {
+ LOG.error("Failed to stop taskMonitor", tt);
+ }
+ }
+
+ if (connectionMonitor != null) {
+ try {
+ actorSystem.stop(connectionMonitor);
+ } catch (Throwable tt) {
+ LOG.error("Failed to stop connectionMonitor",
tt);
+ }
+ }
+
+ if (launchCoordinator != null) {
+ try {
+ actorSystem.stop(launchCoordinator);
+ } catch (Throwable tt) {
+ LOG.error("Failed to stop launchCoordinator",
tt);
+ }
+ }
+
+ if (reconciliationCoordinator != null) {
+ try {
+ actorSystem.stop(reconciliationCoordinator);
+ } catch (Throwable tt) {
+ LOG.error("Failed to stop
reconciliationCoordinator", tt);
+ }
+ }
+
+ if (actorSystem != null) {
+ actorSystem.shutdown();
+ actorSystem.awaitTermination();
+ }
--- End diff --
We cannot shutdown the `ActorSystem` here because it can be used by someone
else outside of the `MesosResourceManager`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
