[
https://issues.apache.org/jira/browse/FLINK-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102913#comment-16102913
]
ASF GitHub Bot commented on FLINK-7125:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129774051
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -163,23 +161,17 @@ public AbstractYarnClusterDescriptor() {
}
}
- // tries to load the config through the environment, if it
fails it can still be set through the setters
- try {
- this.configurationDirectory =
CliFrontend.getConfigurationDirectoryFromEnv();
- this.flinkConfiguration =
GlobalConfiguration.loadConfiguration(configurationDirectory);
+ this.flinkConfiguration =
Preconditions.checkNotNull(flinkConfiguration);
+ userJarInclusion = getUserJarInclusionMode(flinkConfiguration);
- File confFile = new File(configurationDirectory +
File.separator + GlobalConfiguration.FLINK_CONF_FILENAME);
- if (!confFile.exists()) {
- throw new RuntimeException("Unable to locate
configuration file in " + confFile);
- }
- flinkConfigurationPath = new
Path(confFile.getAbsolutePath());
+ this.configurationDirectory =
Preconditions.checkNotNull(configurationDirectory);
+ // tries to load the config through the environment, if it
fails it can still be set through the setters
--- End diff --
is this comment still accurate?
> Remove configuration loading from AbstractYarnClusterDescriptor
> ---------------------------------------------------------------
>
> Key: FLINK-7125
> URL: https://issues.apache.org/jira/browse/FLINK-7125
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> We should remove the explicit configuration loading from the
> {{AbstractYarnClusterDescriptor}} and instead pass it to the class via the
> constructor. This passed in configuration should then be sent to the
> application master when being started. That way, we can easily configure the
> started Yarn cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
