[
https://issues.apache.org/jira/browse/FLINK-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102912#comment-16102912
]
ASF GitHub Bot commented on FLINK-7125:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129768986
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -62,25 +62,27 @@
* Retrieves a client for a running cluster.
* @param commandLine The command-line parameters from the CliFrontend
* @param config The Flink config
+ * @param configurationDirectory Direcotry for configuration files
* @return Client if a cluster could be retrieved
* @throws UnsupportedOperationException if the operation is not
supported
*/
ClusterType retrieveCluster(
- CommandLine commandLine,
- Configuration config) throws
UnsupportedOperationException;
+ CommandLine commandLine,
+ Configuration config,
+ String configurationDirectory) throws
UnsupportedOperationException;
/**
* Creates the client for the cluster.
* @param applicationName The application name to use
* @param commandLine The command-line options parsed by the CliFrontend
* @param config The Flink config to use
- * @param userJarFiles User jar files to include in the classpath of
the cluster.
- * @return The client to communicate with the cluster which the
CustomCommandLine brought up.
+ * @param configurationDirectory
+ *@param userJarFiles User jar files to include in the classpath of the
cluster. @return The client to communicate with the cluster which the
CustomCommandLine brought up.
* @throws Exception if the cluster could not be created
*/
ClusterType createCluster(
- String applicationName,
- CommandLine commandLine,
- Configuration config,
- List<URL> userJarFiles) throws Exception;
+ String applicationName,
+ CommandLine commandLine,
+ Configuration config,
+ String configurationDirectory, List<URL> userJarFiles) throws
Exception;
--- End diff --
nit: broken formatting
> Remove configuration loading from AbstractYarnClusterDescriptor
> ---------------------------------------------------------------
>
> Key: FLINK-7125
> URL: https://issues.apache.org/jira/browse/FLINK-7125
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> We should remove the explicit configuration loading from the
> {{AbstractYarnClusterDescriptor}} and instead pass it to the class via the
> constructor. This passed in configuration should then be sent to the
> application master when being started. That way, we can easily configure the
> started Yarn cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
