[
https://issues.apache.org/jira/browse/FLINK-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102905#comment-16102905
]
ASF GitHub Bot commented on FLINK-7125:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129777841
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -722,12 +697,30 @@ public ApplicationReport startAppMaster(JobGraph
jobGraph, YarnClient yarnClient
// Setup jar for ApplicationMaster
LocalResource appMasterJar =
Records.newRecord(LocalResource.class);
- LocalResource flinkConf =
Records.newRecord(LocalResource.class);
--- End diff --
nit: for me it would be easier to understand/review the changes done here,
if there was a separate PR for changing formatting (splitting one param per
line)
> Remove configuration loading from AbstractYarnClusterDescriptor
> ---------------------------------------------------------------
>
> Key: FLINK-7125
> URL: https://issues.apache.org/jira/browse/FLINK-7125
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> We should remove the explicit configuration loading from the
> {{AbstractYarnClusterDescriptor}} and instead pass it to the class via the
> constructor. This passed in configuration should then be sent to the
> application master when being started. That way, we can easily configure the
> started Yarn cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
