Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4473#discussion_r131578056
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java
 ---
    @@ -24,10 +24,30 @@
      */
     public class ProducerConfigConstants extends AWSConfigConstants {
     
    -   /** Maximum number of items to pack into an PutRecords request. **/
    +   /** Maximum number of KPL user records to store in a single Kinesis 
Streams record (an aggregated record). */
    +   public static final String AGGREGATION_MAX_COUNT = 
"aws.producer.aggregationMaxCount";
    +
    +   /** Maximum number of Kinesis Streams records to pack into an 
PutRecords request. */
        public static final String COLLECTION_MAX_COUNT = 
"aws.producer.collectionMaxCount";
     
    -   /** Maximum number of items to pack into an aggregated record. **/
    -   public static final String AGGREGATION_MAX_COUNT = 
"aws.producer.aggregationMaxCount";
    +   /** Maximum number of connections to open to the backend. HTTP requests 
are
    +    * sent in parallel over multiple connections */
    --- End diff --
    
    Style consistency: missing period at the end.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to