[ 
https://issues.apache.org/jira/browse/FLINK-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119834#comment-16119834
 ] 

ASF GitHub Bot commented on FLINK-7395:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4504

    [FLINK-7395] [metrics] Count bytesIn/Out without synchronization

    ## What is the purpose of the change
    
    This PR changes the numBytesIn/Out measurement to not use the synchronized 
`Buffer#getSize()` method.
    
    
    ## Brief change log
    
      - Add unsynchronized ┬┤Buffer#getSizeUnsafe()`
      - replace all calls by the metric system to  `Buffer#getSize()` 
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): yes 
(technically it's per-buffer, but i guess that still counts)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7395

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4504
    
----
commit c6f566916aab4b74b6437b6a153a189c6e17e793
Author: zentol <ches...@apache.org>
Date:   2017-08-09T12:43:51Z

    [FLINK-7395] [metrics] Count bytesIn/Out without synchronization

----


> NumBytesOut metric in RecordWriter call synchronized method
> -----------------------------------------------------------
>
>                 Key: FLINK-7395
>                 URL: https://issues.apache.org/jira/browse/FLINK-7395
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.4.0, 1.3.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.4.0, 1.3.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to