[
https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143451#comment-16143451
]
ASF GitHub Bot commented on FLINK-7378:
---------------------------------------
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4485
For `ResultPartitionType` comment, I expand to add the 'isCreditBased'
field temporarily in order not to affect the current process. My initial idea
is to remove this field after the whole feature is verified to enable. If you
approve this as a formal way, I will add the new mode
`PIPELINE_CREDIT_BASED(true, true, true, true)` and javadoc for it.
For `gate.setBufferPool(bufferPool)`, it is my carelessness to not add it.
For releasing segments when exception, it is actually better to process
inside the method of `NetworkBufferPool`.
I will submit the modifications later today.
> Create a fix size (non rebalancing) buffer pool type for the floating buffers
> -----------------------------------------------------------------------------
>
> Key: FLINK-7378
> URL: https://issues.apache.org/jira/browse/FLINK-7378
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> Currently the number of network buffers in {{LocalBufferPool}} for
> {{SingleInputGate}} is limited by {{a * <number of channels> + b}}, where a
> is the number of exclusive buffers for each channel and b is the number of
> floating buffers shared by all channels.
> Considering the credit-based flow control feature, we want to create a fix
> size buffer pool used to manage the floating buffers for {{SingleInputGate}}.
> And the exclusive buffers are assigned to {{InputChannel}}s directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
