[
https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143560#comment-16143560
]
ASF GitHub Bot commented on FLINK-7378:
---------------------------------------
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4485
Hi @zhijiangW,
regarding the buffer pool implementation, I was just curious about why it
was done that way. But it is fine to keep the logic in `RemoteInputChannel` if
you make sure, that a recycler puts these buffers right (back) into the buffer
queue (I guess, that's in one of the follow-up PRs). This way, we avoid an
additional intermediate component (and the need to interact with it). To
conclude, on a second thought, it is fine as it is.
The thing with `ResultPartitionType` is that without an (intermediate) way
to set `isCreditBased` to `true`, we are not really able to test this code path
on higher levels such as the `NetworkEnvironment` (or maybe I'll see that in
the follow-up PRs as well).
Speaking of tests...I understand that with the switch to credit-based flow
control, some parts will be covered by existing tests, but we also change the
behaviour at some points and the current tests are already a bit sparse. Can
you also add tests for
- the `NetworkEnvironment` changes (into `NetworkEnvironmentTest`),
- `NetworkBufferPool#requestMemorySegments`,
`NetworkBufferPool#recycleMemorySegments` (into `NetworkBufferPoolTest` which
currently is a bit sparse though)
- the changes in `SingleInputGate` (into `SingleInputGateTest`)
> Create a fix size (non rebalancing) buffer pool type for the floating buffers
> -----------------------------------------------------------------------------
>
> Key: FLINK-7378
> URL: https://issues.apache.org/jira/browse/FLINK-7378
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> Currently the number of network buffers in {{LocalBufferPool}} for
> {{SingleInputGate}} is limited by {{a * <number of channels> + b}}, where a
> is the number of exclusive buffers for each channel and b is the number of
> floating buffers shared by all channels.
> Considering the credit-based flow control feature, we want to create a fix
> size buffer pool used to manage the floating buffers for {{SingleInputGate}}.
> And the exclusive buffers are assigned to {{InputChannel}}s directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
