Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4499#discussion_r140810853
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ---
    @@ -99,8 +114,24 @@ public RemoteInputChannel(
                this.connectionManager = checkNotNull(connectionManager);
        }
     
    +   /**
    +    * Assigns exclusive buffers to this input channel, and this method 
should be called only once
    +    * after this input channel is created.
    +    */
        void assignExclusiveSegments(List<MemorySegment> segments) {
    -           // TODO in next PR
    +           checkState(this.initialCredit == 0, "Bug in input channel setup 
logic: exclusive buffers have" +
    +                   "already been set for this input channel.");
    --- End diff --
    
    please add a space between `have` and `already` (between the concatenations)


---

Reply via email to