Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r140831302 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -183,18 +214,40 @@ void notifySubpartitionConsumed() { } /** - * Releases all received buffers and closes the partition request client. + * Releases all received and available buffers, closes the partition request client. */ @Override void releaseAllResources() throws IOException { if (isReleased.compareAndSet(false, true)) { + + final List<MemorySegment> recyclingSegments = new ArrayList<>(); + synchronized (receivedBuffers) { Buffer buffer; while ((buffer = receivedBuffers.poll()) != null) { - buffer.recycle(); + if (buffer.getRecycler() == this) { + recyclingSegments.add(buffer.getMemorySegment()); --- End diff -- ok - regarding `RemoteInputChannel#recycle()`, if we use this here (indirectly via `buffer.recycle`), we would not want it to redistribute buffers for every single `recycle()` call, but if `RemoteInputChannel#recycle()` is called for a single buffer outside `RemoteInputChannel#releaseAllResources()`, we would want it to do that... You're right that this would create some mess there and we should probably keep your current solution unless something better comes to mind.
---