GitHub user zhijiangW opened a pull request:

    https://github.com/apache/flink/pull/4735

    [FLINK-7699][core] Define the BufferListener interface to replace 
EventlListener in BufferProvider

    ## What is the purpose of the change
    
    *Currently the EventListener is used in BufferProvider to be notified of 
buffer available or destroyed pool.*
    
    *To be semantic clearly, we define a new BufferListener interface which can 
opt for a one-time only notification or to be notified repeatedly. And we can 
also notify the pool destroyed via explicitly method notifyBufferDestroyed.*
    
    This RP is based on #4499 whose commit is also included for passing travis. 
Review the third commit for this PR change.
    
    ## Brief change log
    
      - *The `RemoteInputChannel` will implement the `BufferListener` to wait 
for floating buffers from `BufferProvider`.*
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as 
*LocalBufferPoolTest*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhijiangW/flink FLINK-7699

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4735
    
----

----


---

Reply via email to