Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141387553
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -313,6 +320,49 @@ public int getNumberOfAvailableBuffers() {
}
}
+ /**
+ * Buffer pool notifies this channel of an available floating buffer.
If the channel is released or not
+ * needing extra buffers currently, the buffer should be recycled to
buffer pool. Otherwise, the buffer
+ * will be added into the available queue and the unannounced credit is
increased by one.
+ *
+ * @param buffer Buffer that becomes available in buffer pool.
+ * @return True when this channel is waiting for more floating buffers,
otherwise false.
+ */
+ @Override
+ public boolean notifyBufferAvailable(Buffer buffer) {
+ checkState(isWaitingFloatingBuffers.get(), "This channel should
be waiting for floating buffers currently.");
--- End diff --
`"This channel should be waiting for floating buffers."`
---
