Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141388702
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java
---
@@ -211,10 +210,15 @@ public void testSetLessThanRequiredNumBuffers()
throws IOException {
@Test
public void testPendingRequestWithListenerAfterRecycle() throws
Exception {
- EventListener<Buffer> listener = spy(new
EventListener<Buffer>() {
+ BufferListener listener = spy(new BufferListener() {
@Override
- public void onEvent(Buffer buffer) {
+ public boolean notifyBufferAvailable(Buffer buffer) {
buffer.recycle();
+ return false;
--- End diff --
can you also add a test which verifies that requests for multiple buffers,
i.e. returning `true` here, works?
---
