[
https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207717#comment-16207717
]
Timo Walther commented on FLINK-7548:
-------------------------------------
Thanks for the proposal [~fhueske]. I like the idea with a separate
{{TableSchema}} for sources that a user can implement. Maybe we can simplify
the design even more by extending {{TableSchema}} with additional methods like
{{setRowtime(TimestampExtractor, WatermarkAssigner), setProctime()}}. Then, we
would not need the {{DefinedProctimeAttribute}} and
{{DefinedRowtimeAttributes}} interfaces anymore. If we want to change the logic
in the future, we don't have to modify interfaces but can deprecate or add
additional methods to {{TableSchema}}. Having {{setRowtime/setProctime()}}
would also hide the internal {{TimeIndicatorType}} but would not require to
define a field name twice (in TableSchema and DefinedProctimeAttribute). What
do you think?
> Support watermark generation for TableSource
> --------------------------------------------
>
> Key: FLINK-7548
> URL: https://issues.apache.org/jira/browse/FLINK-7548
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Fabian Hueske
> Priority: Blocker
> Fix For: 1.4.0
>
>
> As discussed in FLINK-7446, currently the TableSource only support to define
> rowtime field, but not support to extract watermarks from the rowtime field.
> We can provide a new interface called {{DefinedWatermark}}, which has two
> methods {{getRowtimeAttribute}} (can only be an existing field) and
> {{getWatermarkGenerator}}. The {{DefinedRowtimeAttribute}} will be marked
> deprecated.
> How to support periodic and punctuated watermarks and support some built-in
> strategies needs further discussion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
