[
https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221807#comment-16221807
]
ASF GitHub Bot commented on FLINK-7548:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146584051
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -246,40 +245,31 @@ abstract class CodeGenerator(
*/
def generateConverterResultExpression(
returnType: TypeInformation[_ <: Any],
- resultFieldNames: Seq[String])
+ resultFieldNames: Seq[String],
+ rowtimeExpression: Option[RexNode] = None)
: GeneratedExpression = {
val input1AccessExprs = input1Mapping.map {
- case TimeIndicatorTypeInfo.ROWTIME_MARKER =>
- // attribute is a rowtime indicator. Access event-time timestamp
in StreamRecord.
- generateRowtimeAccess()
- case TimeIndicatorTypeInfo.PROCTIME_MARKER =>
+ case TimeIndicatorTypeInfo.ROWTIME_STREAM_MARKER |
+ TimeIndicatorTypeInfo.ROWTIME_BATCH_MARKER =>
+ // attribute is a rowtime indicator.
+ if (rowtimeExpression.isDefined) {
--- End diff --
We could use pattern matching here.
> Support watermark generation for TableSource
> --------------------------------------------
>
> Key: FLINK-7548
> URL: https://issues.apache.org/jira/browse/FLINK-7548
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Fabian Hueske
> Priority: Blocker
> Fix For: 1.4.0
>
>
> As discussed in FLINK-7446, currently the TableSource only support to define
> rowtime field, but not support to extract watermarks from the rowtime field.
> We can provide a new interface called {{DefinedWatermark}}, which has two
> methods {{getRowtimeAttribute}} (can only be an existing field) and
> {{getWatermarkGenerator}}. The {{DefinedRowtimeAttribute}} will be marked
> deprecated.
> How to support periodic and punctuated watermarks and support some built-in
> strategies needs further discussion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
