Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4840#discussion_r146825517
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStoreTest.java
---
@@ -58,9 +59,9 @@ public void testMalformedNameHandling() {
store.add(cd);
//-----verify that no side effects occur
- assertEquals(0, store.jobManager.metrics.size());
- assertEquals(0, store.taskManagers.size());
- assertEquals(0, store.jobs.size());
+ assertTrue(store.getTaskManagers().isEmpty());
--- End diff --
i actually prefer the previous version as it prints the actual value.
---
