Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4840#discussion_r146825384
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java
 ---
    @@ -260,50 +293,66 @@ public String getMetric(String name, String 
defaultValue) {
                                ? value
                                : defaultValue;
                }
    -   }
     
    -   /**
    -    * Sub-structure containing metrics of the JobManager.
    -    */
    -   public static class JobManagerMetricStore extends ComponentMetricStore {
    +           public static ComponentMetricStore 
unmodifiable(ComponentMetricStore source) {
    --- End diff --
    
    can be private


---

Reply via email to