[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r146585641
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 ---
    @@ -1332,6 +1322,11 @@ abstract class CodeGenerator(
         GeneratedExpression(resultTerm, NEVER_NULL, resultCode, 
SqlTimeTypeInfo.TIMESTAMP)
       }
     
    +  private[flink] def generateCurrentTimestamp(): GeneratedExpression = {
    +    val rexBuilder = new RexBuilder(new FlinkTypeFactory(new 
FlinkTypeSystem))
    +    generateExpression(rexBuilder.makeCall(CURRENT_TIMESTAMP))
    --- End diff --
    
    Use `new CurrentTimePointCallGen().generate()` instead of create a whole 
new type environment ;)


---