[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r146583860
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 ---
    @@ -246,40 +245,31 @@ abstract class CodeGenerator(
         */
       def generateConverterResultExpression(
           returnType: TypeInformation[_ <: Any],
    -      resultFieldNames: Seq[String])
    +      resultFieldNames: Seq[String],
    +      rowtimeExpression: Option[RexNode] = None)
    --- End diff --
    
    Add the Scala doc for the parameter.


---