[GitHub] flink pull request #4894: [FLINK-7548] [table] Improve rowtime support of Ta...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4894#discussion_r146574319
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
 ---
    @@ -84,6 +86,13 @@
                return typeInfo;
        }
     
    +   @Override
    +   public TableSchema getTableSchema() {
    +           return new TableSchema(
    +                   ((RowTypeInfo) typeInfo).getFieldNames(),
    --- End diff --
    
    Maybe we should add a constructor or method to `TableSchema` that takes a 
TypeInfo. I think this case is very common for table sources.


---