[
https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221813#comment-16221813
]
ASF GitHub Bot commented on FLINK-7548:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r146575110
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java
---
@@ -89,34 +98,50 @@ public void addColumn(String family, String qualifier,
Class<?> clazz) {
* @param charset Name of the charset to use.
*/
public void setCharset(String charset) {
- this.schema.setCharset(charset);
+ this.hBaseSchema.setCharset(charset);
}
@Override
public TypeInformation<Row> getReturnType() {
- String[] famNames = schema.getFamilyNames();
- TypeInformation<?>[] typeInfos = new
TypeInformation[famNames.length];
+ return new RowTypeInfo(getFieldTypes(), getFieldNames());
+ }
+
+ public TableSchema getTableSchema() {
--- End diff --
Add `@Override` annotation.
> Support watermark generation for TableSource
> --------------------------------------------
>
> Key: FLINK-7548
> URL: https://issues.apache.org/jira/browse/FLINK-7548
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Fabian Hueske
> Priority: Blocker
> Fix For: 1.4.0
>
>
> As discussed in FLINK-7446, currently the TableSource only support to define
> rowtime field, but not support to extract watermarks from the rowtime field.
> We can provide a new interface called {{DefinedWatermark}}, which has two
> methods {{getRowtimeAttribute}} (can only be an existing field) and
> {{getWatermarkGenerator}}. The {{DefinedRowtimeAttribute}} will be marked
> deprecated.
> How to support periodic and punctuated watermarks and support some built-in
> strategies needs further discussion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
