Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4937#discussion_r148599674
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPoolGateway.java
---
@@ -86,10 +85,16 @@
//
------------------------------------------------------------------------
CompletableFuture<SimpleSlot> allocateSlot(
- ScheduledUnit task,
+ AllocationID allocationID,
ResourceProfile resources,
Iterable<TaskManagerLocation> locationPreferences,
@RpcTimeout Time timeout);
void returnAllocatedSlot(Slot slot);
+
+ /**
+ * Cancel a slot allocation.
+ * This method should be called when the CompletableFuture returned by
allocateSlot completed exceptionally.
--- End diff --
Params description is missing.
---
