Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4937#discussion_r148571851
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -294,11 +296,11 @@ public void returnAllocatedSlot(Slot slot) {
}
}
- private static ResourceManagerGateway
createResourceManagerGatewayMock() {
+ static ResourceManagerGateway createResourceManagerGatewayMock() {
ResourceManagerGateway resourceManagerGateway =
mock(ResourceManagerGateway.class);
when(resourceManagerGateway
- .requestSlot(any(JobMasterId.class),
any(SlotRequest.class), any(Time.class)))
- .thenReturn(mock(CompletableFuture.class,
RETURNS_MOCKS));
+ .requestSlot(any(JobMasterId.class),
any(SlotRequest.class), any(Time.class)))
+ .thenReturn(mock(CompletableFuture.class,
RETURNS_MOCKS));
--- End diff --
Why not returning a proper `CompletableFuture` here?
---
