Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4937#discussion_r148592528
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -361,9 +374,19 @@ private void
slotRequestToResourceManagerFailed(AllocationID allocationID, Throw
}
private void checkTimeoutSlotAllocation(AllocationID allocationID) {
+ removePendingRequestWithException(allocationID, new
TimeoutException("Slot allocation request " + allocationID + " timed out"));
+ }
+
+ private void removePendingRequestWithException(AllocationID
allocationID, Exception e) {
--- End diff --
maybe we could refactor this method into
`failPendingRequest(PendingRequest, Exception)`, then it could be used by
`checkTimeoutSlotAllocation` and `checkTimeoutRequestWaitingForResourceManager`
---
