Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153269318
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -283,10 +283,13 @@ public String toString() {
//
------------------------------------------------------------------------
/**
- * Enqueue this input channel in the pipeline for sending unannounced
credits to producer.
+ * Enqueue this input channel in the pipeline for notifying the
producer of unannounced credit.
*/
void notifyCreditAvailable() {
- //TODO in next PR
+ // We should skip the notification if this channel is already
released.
+ if (!isReleased.get() && partitionRequestClient != null) {
--- End diff --
shouldn't we
```
checkState(partitionRequestClient != null, "Tried to send
credit announcement to producer before requesting a queue.");`
```
here as well? At the moment I don't see a valid usecase for `== null` and
only a potential problem with the notification not being tried again.
---
