Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153258008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -88,6 +98,15 @@ void cancelRequestFor(InputChannelID inputChannelId) {
}
}
+ void notifyCreditAvailable(final RemoteInputChannel inputChannel) {
--- End diff --
Can you please add a comment under which circumstances not to call this,
i.e. we must make sure, `ctx` is assigned yet (so after the channel has been
activated somehow). I checked the uses of this method and those seem to be
safe, i.e. in `RemoteInputChannel`s `#notifyBufferAvailable()`,
`#onSenderBacklog()`, and `#recycle()`. All of these should only happen after
some interaction with the channel.
---
