[
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294975#comment-16294975
]
ASF GitHub Bot commented on FLINK-8234:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157480732
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/queue/QueueStatus.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.queue;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Response type for temporary queue resources, i.e., resources that are
asynchronously created.
+ *
+ * @see org.apache.flink.runtime.rest.handler.job.JobExecutionResultHandler
+ */
+public class QueueStatus implements ResponseBody {
+
+ private static final String FIELD_NAME_STATUS = "id";
+
+ @JsonProperty(value = FIELD_NAME_STATUS, required = true)
+ private final StatusId statusId;
+
+ @JsonCreator
+ public QueueStatus(
+ @JsonProperty(value = FIELD_NAME_STATUS, required = true) final
StatusId statusId) {
+ this.statusId = requireNonNull(statusId, "statusId must not be
null");
+ }
+
+ public static QueueStatus inProgress() {
+ return new QueueStatus(StatusId.IN_PROGRESS);
+ }
+
+ public static QueueStatus created() {
+ return new QueueStatus(StatusId.CREATED);
+ }
+
+ public StatusId getStatusId() {
+ return statusId;
+ }
+
+ /**
+ * Defines queue statuses.
+ */
+ public enum StatusId {
+ IN_PROGRESS,
+ CREATED
--- End diff --
`CREATED` somewhat confused me. Maybe we could rename it into `DONE` or
`COMPLETED`.
> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
> Key: FLINK-8234
> URL: https://issues.apache.org/jira/browse/FLINK-8234
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should
> have a configurable size and should periodically clean up stale entries in
> order to avoid memory leaks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
