[
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297433#comment-16297433
]
ASF GitHub Bot commented on FLINK-8234:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5184
[FLINK-8234][flip6] Cache JobExecutionResult in Dispatcher
## What is the purpose of the change
Cache `JobExecutionResult` in `Dispatcher`, and add methods to
`RestfulGateway` to enable retrieval of results through HTTP (not yet
implemented). This will be needed so that accumulator results can be
transmitted to the client.
## Brief change log
- *Introduce new JobExecutionResult used by JobMaster to forward the
information in the already existing JobExecutionResult.*
- *Always cache a JobExecutionResult. Even in case of job failures. In
case of job failures, the serialized exception is stored additionally.*
- *Introduce new methods to RestfulGateway to allow retrieval of cached
JobExecutionResults.*
## Verifying this change
This change added tests and can be verified as follows:
- *Added unit tests to verify that the Dispatcher caches the job results
when the job finishes successfully or by failure.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
CC: @tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-8234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5184
----
commit d05c76e621106810c32bc17aa0576923ba6be401
Author: gyao <[email protected]>
Date: 2017-12-19T17:58:53Z
[FLINK-8234][flip6] Cache JobExecutionResult in Dispatcher
- Introduce new JobExecutionResult used by JobMaster to forward the
information in
the already existing JobExecutionResult.
- Always cache a JobExecutionResult. Even in case of job failures. In case
of
job failures, the serialized exception is stored additionally.
- Introduce new methods to RestfulGateway to allow retrieval of cached
JobExecutionResults
----
> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
> Key: FLINK-8234
> URL: https://issues.apache.org/jira/browse/FLINK-8234
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should
> have a configurable size and should periodically clean up stale entries in
> order to avoid memory leaks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
