[
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297450#comment-16297450
]
ASF GitHub Bot commented on FLINK-8234:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r157878862
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java
---
@@ -358,12 +360,12 @@ private DetachedFinalizer(JobID jobID, int
numJobManagersToWaitFor) {
}
@Override
- public void jobFinished(JobExecutionResult result) {
+ public void
jobFinished(org.apache.flink.runtime.jobmaster.JobExecutionResult result) {
decrementCheckAndCleanup();
}
@Override
- public void jobFailed(Throwable cause) {
+ public void
jobFailed(org.apache.flink.runtime.jobmaster.JobExecutionResult result) {
--- End diff --
Maybe rename to `JobResult` after all to avoid fqn.
> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
> Key: FLINK-8234
> URL: https://issues.apache.org/jira/browse/FLINK-8234
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should
> have a configurable size and should periodically clean up stale entries in
> order to avoid memory leaks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
