[
https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307274#comment-16307274
]
ASF GitHub Bot commented on FLINK-8333:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5220
[FLINK-8333] [flip6] Separate deployment options from command options
## What is the purpose of the change
This commit separates the parsing of command options and deployment options
into two
steps. This makes it easier to make the CustomCommandLines non-static.
Moreover, this commit moves the CliFrontend into the cli sub package.
This PR is based on #5219.
## Brief change log
- Move `CliFrontend` to `org.apache.flink.client.cli`
- Decouple creation of `RunOptions`, `ListOptions`, etc. from
`CliFrontendParser`
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink splitCliOptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5220
----
commit c48324702b0ebff3fd7a16e480ead90fc4c9a30b
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-07T12:57:24Z
[FLINK-8328] [flip6] Move Yarn ApplicationStatus polling out of
YarnClusterClient
Introduce YarnApplicationStatusMonitor which does the Yarn
ApplicationStatus polling in
the FlinkYarnSessionCli. This decouples the YarnClusterClient from the
actual communication
with Yarn and, thus, gives a better separation of concerns.
commit 783bd1daf36b34a74cbe718a52a1043ba38d5a44
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-20T15:43:21Z
[FLINK-8329] [flip6] Move YarnClient to AbstractYarnClusterDescriptor
Moves the YarnClient from the YarnClusterClient to the
AbstractYarnClusterDescriptor.
This makes the latter responsible for the lifecycle management of the
client and gives
a better separation of concerns.
commit 0cd22bf559eb820f3e2d381686752f583f4f16ff
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-18T17:59:30Z
[FLINK-8332] [flip6] Move savepoint dispose into ClusterClient
Move the savepoint disposal logic from the CliFrontend into the
ClusterClient. This gives
a better separation of concerns and allows the CliFrontend to be used with
different
ClusterClient implementations.
commit 2b4c1efb79ffdfd1423240047dce8e2f038958c7
Author: Till Rohrmann <trohrmann@...>
Date: 2017-12-20T16:19:59Z
[FLINK-8333] [flip6] Separate deployment options from command options
This commit separates the parsing of command options and deployment options
into two
steps. This makes it easier to make the CustomCommandLines non-static.
Moreover, this commit moves the CliFrontend into the cli sub package.
----
> Split command options from deployment options in CliFrontend
> ------------------------------------------------------------
>
> Key: FLINK-8333
> URL: https://issues.apache.org/jira/browse/FLINK-8333
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to better support different {{CustomCommandLines}} we should split
> the command and deployment option parsing in the {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
