[
https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309755#comment-16309755
]
ASF GitHub Bot commented on FLINK-8333:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159425958
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -274,19 +251,13 @@ protected int run(String[] args) {
return executeProgram(program, client, userParallelism);
}
- catch (Throwable t) {
- return handleError(t);
- }
finally {
- if (client != null) {
- try {
- client.shutdown();
- } catch (Exception e) {
- LOG.warn("Could not properly shut down
the cluster client.", e);
- }
- }
- if (program != null) {
- program.deleteExtractedLibraries();
+ program.deleteExtractedLibraries();
--- End diff --
This won't run if `createClient()` fails. Before the client creation was
inside the `try` block.
> Split command options from deployment options in CliFrontend
> ------------------------------------------------------------
>
> Key: FLINK-8333
> URL: https://issues.apache.org/jira/browse/FLINK-8333
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to better support different {{CustomCommandLines}} we should split
> the command and deployment option parsing in the {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
