[
https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309632#comment-16309632
]
ASF GitHub Bot commented on FLINK-8333:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159422003
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
retrieveClient(CommandLineOptions options) {
}
}
- /**
- * Retrieves the {@link ActorGateway} for the JobManager. The
ClusterClient is retrieved
- * from the provided {@link CommandLineOptions}.
- *
- * @param options CommandLineOptions specifying the JobManager URL
- * @return Gateway to the JobManager
- * @throws Exception
- */
- protected ActorGateway getJobManagerGateway(CommandLineOptions options)
throws Exception {
- logAndSysout("Retrieving JobManager.");
- return retrieveClient(options).getJobManagerGateway();
- }
-
/**
* Creates a {@link ClusterClient} object from the given command line
options and other parameters.
- * @param options Command line options
+ * @param customCommandLine custom command line to use to retrieve the
client
+ * @param commandLine command line to use
* @param program The program for which to create the client.
* @throws Exception
*/
protected ClusterClient createClient(
- CommandLineOptions options,
+ CustomCommandLine<?> customCommandLine,
--- End diff --
Was it really necessary to change the signature? It seems that the behavior
is otherwise the same. Why not leave the line
```
CustomCommandLine<?> activeCommandLine =
getActiveCustomCommandLine(options.getCommandLine());
```
inside this method.
> Split command options from deployment options in CliFrontend
> ------------------------------------------------------------
>
> Key: FLINK-8333
> URL: https://issues.apache.org/jira/browse/FLINK-8333
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to better support different {{CustomCommandLines}} we should split
> the command and deployment option parsing in the {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
