[
https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309499#comment-16309499
]
ASF GitHub Bot commented on FLINK-8332:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r159400326
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -149,23 +153,26 @@ public void testTriggerSavepointFailureIllegalJobID()
throws Exception {
public void testTriggerSavepointCustomTarget() throws Exception {
replaceStdOutAndStdErr();
- try {
- JobID jobId = new JobID();
+ JobID jobId = new JobID();
- String savepointDirectory = "customTargetDirectory";
+ String savepointDirectory = "customTargetDirectory";
- MockedCliFrontend frontend = new
SavepointTestCliFrontend(savepointDirectory);
+ final ClusterClient clusterClient =
createClusterClient(savepointDirectory);
+
+ try {
+ MockedCliFrontend frontend = new
MockedCliFrontend(clusterClient);
String[] parameters = { jobId.toString(),
savepointDirectory };
- int returnCode = frontend.savepoint(parameters);
+ frontend.savepoint(parameters);
- assertEquals(0, returnCode);
--- End diff --
Is there a reason why this assertion was removed? I think it would still
pass.
> Move dispose savepoint into ClusterClient
> -----------------------------------------
>
> Key: FLINK-8332
> URL: https://issues.apache.org/jira/browse/FLINK-8332
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Currently, the {{CliFrontend}} sends the command for disposing a savepoint.
> In order to better abstract this functionality we should move it to the
> {{ClusterClient}}. That way we can have different implementations of the
> {{ClusterClient}} (Flip-6 and old code) which are used by the same
> {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
