[
https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320373#comment-16320373
]
ASF GitHub Bot commented on FLINK-8332:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r160699213
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -128,13 +131,14 @@ public void testTriggerSavepointFailureIllegalJobID()
throws Exception {
replaceStdOutAndStdErr();
try {
- CliFrontend frontend = new
CliFrontend(CliFrontendTestUtils.getConfigDir());
+ CliFrontend frontend = new MockedCliFrontend(new
StandaloneClusterClient(
+ new Configuration(),
+ new TestingHighAvailabilityServices()));
String[] parameters = { "invalid job id" };
int returnCode = frontend.savepoint(parameters);
- assertTrue(returnCode != 0);
- assertTrue(buffer.toString().contains("not a valid
ID"));
--- End diff --
True. Will re-add for the sake of correctness.
> Move dispose savepoint into ClusterClient
> -----------------------------------------
>
> Key: FLINK-8332
> URL: https://issues.apache.org/jira/browse/FLINK-8332
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Currently, the {{CliFrontend}} sends the command for disposing a savepoint.
> In order to better abstract this functionality we should move it to the
> {{ClusterClient}}. That way we can have different implementations of the
> {{ClusterClient}} (Flip-6 and old code) which are used by the same
> {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
