[ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309787#comment-16309787 ]
ASF GitHub Bot commented on FLINK-8333: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5220#discussion_r159447901 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -1,170 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.client; - -import org.apache.flink.client.cli.CliFrontendParser; -import org.apache.flink.client.cli.Flip6DefaultCLI; -import org.apache.flink.client.cli.RunOptions; -import org.apache.flink.client.program.ClusterClient; -import org.apache.flink.client.program.PackagedProgram; -import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings; - -import org.junit.BeforeClass; -import org.junit.Test; - -import static org.apache.flink.client.CliFrontendTestUtils.getTestJarPath; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotEquals; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; - -/** - * Tests for the RUN command. - */ -public class CliFrontendRunTest { --- End diff -- File is not recognized as *moved* by git 😢 > Split command options from deployment options in CliFrontend > ------------------------------------------------------------ > > Key: FLINK-8333 > URL: https://issues.apache.org/jira/browse/FLINK-8333 > Project: Flink > Issue Type: Sub-task > Components: Client > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > Fix For: 1.5.0 > > > In order to better support different {{CustomCommandLines}} we should split > the command and deployment option parsing in the {{CliFrontend}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)