[
https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320445#comment-16320445
]
ASF GitHub Bot commented on FLINK-8333:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r160711940
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -515,33 +464,28 @@ protected int stop(String[] args) {
if (stopArgs.length > 0) {
String jobIdString = stopArgs[0];
- try {
- jobId = new
JobID(StringUtils.hexStringToByte(jobIdString));
- }
- catch (Exception e) {
- return handleError(e);
- }
+ jobId = new
JobID(StringUtils.hexStringToByte(jobIdString));
--- End diff --
Good point. Will throw a more meaningful exception.
> Split command options from deployment options in CliFrontend
> ------------------------------------------------------------
>
> Key: FLINK-8333
> URL: https://issues.apache.org/jira/browse/FLINK-8333
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to better support different {{CustomCommandLines}} we should split
> the command and deployment option parsing in the {{CliFrontend}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
