Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r159840075
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -831,11 +834,12 @@ private StreamStateHandle materializeStateData(Path 
filePath) throws Exception {
                                return result;
     
                        } finally {
    -                           if (inputStream != null && 
closeableRegistry.unregisterCloseable(inputStream)) {
    +
    +                           if 
(closeableRegistry.unregisterCloseable(inputStream)) {
    --- End diff --
    
    Is it unrelated refactor/clean up? If so please move to separate commit. 
(ditto for other `xyz != null` checks removal)
      


---

Reply via email to