Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r159860788
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -1041,7 +1045,13 @@ public void restore(Collection<KeyedStateHandle>
restoreState) throws Exception
@Override
public void notifyCheckpointComplete(long completedCheckpointId) {
+
+ if (!enableIncrementalCheckpointing) {
--- End diff --
?
1. Is this change relevant to the commit? If not please extract it to
separate one.
2. Why we do not need to handle notify for disabled incremental
checkpointing? Doesn't it deserve some explanation in form of a comment?
---
