Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r159863616
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
@@ -375,11 +376,13 @@ public void declareOutputFields(OutputFieldsDeclarer
declarer) {
when(env.getMetricGroup()).thenReturn(new
UnregisteredTaskMetricsGroup());
when(env.getTaskManagerInfo()).thenReturn(new
TestingTaskManagerRuntimeInfo());
+ final CloseableRegistry closeableRegistry = new
CloseableRegistry();
StreamTask<?, ?> mockTask = mock(StreamTask.class);
when(mockTask.getCheckpointLock()).thenReturn(new Object());
when(mockTask.getConfiguration()).thenReturn(new
StreamConfig(new Configuration()));
when(mockTask.getEnvironment()).thenReturn(env);
when(mockTask.getExecutionConfig()).thenReturn(execConfig);
+ when(mockTask.getCancelables()).thenReturn(closeableRegistry);
--- End diff --
Mockito as always!
Why not replace this ugly block with `NoOpStreamTask` or something else
implementing `StreamTask`? It will save the hassle for next developer that will
try to call some other method from this mock, that wasn't defined properly.
---
